tag:help.lighthouseapp.com,2008-09-20:/discussions/problems/14419-non-standard-yaml-formatLighthouse: Discussion 2013-04-26T14:05:58Ztag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-15T18:01:35Z2013-04-15T18:01:35ZNon standard YAML format?<div><p>Hey Frank,</p>
<p>No idea. You're looking at code probably from 2006. But here's
how Github posts their changesets to us, written by the same guy
who wrote the changeset code:</p>
<p><a href=
"https://github.com/github/github-services/blob/master/lib/services/lighthouse.rb">
https://github.com/github/github-services/blob/master/lib/services/...</a></p></div>Tiger Teamtag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-15T18:07:55Z2013-04-15T18:07:55ZNon standard YAML format?<div><p>I just did a bit of digging for you; you're right, it really
should just parse a chunk of text.</p></div>Tiger Teamtag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-15T18:17:56Z2013-04-15T21:15:01ZNon standard YAML format?<div><p>Courtenay, thanks for digging. Good to know I'm not the crazy
one.</p>
<p>So the guy who wrote the GitHub integration was responsible for
the original spec for changesets within Lighthouse? As in he used
to work for entp? You guys are probably better off... ;-)</p>
<p><strong>(Edit)</strong> So when can I expect to see an update
eliminating these YAML hoops?</p></div>Frank Koehltag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-16T00:41:03Z2013-04-16T00:41:03ZNon standard YAML format?<div><p>Hey Frank,</p>
<p>You can try and provide the simpler version:</p>
<pre>
<code>A somefile
M otherfile
...</code>
</pre>
<p>Let me know how it goes.</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-16T13:20:47Z2013-04-16T13:20:47ZNon standard YAML format?<div><p>Thanks, Julien, that <em>almost</em> worked flawlessly.</p>
<p>My example was too simple. Git and Subversion both produce the
file list with multiple spaces between the status character
(<code>A</code>, <code>M</code>, <code>D</code>, <code>R</code>,
etc...) and the file name. In other words, the modified file list
is not restricted to a <strong>single</strong> space. Your
implementation requires a single space, when it should look for any
number of uninterrupted spaces.</p>
<pre>
<code># My original example
M /trunk/test/unit/changeset_test.rb
M /trunk/app/models/changeset.rb
M /trunk/db/schema.rb
# A more accurate representation
M /trunk/test/unit/changeset_test.rb
M /trunk/app/models/changeset.rb
M /trunk/db/schema.rb</code>
</pre>
<p>Here's the Git command to produce the list I described
above...</p>
<pre>
<code>git diff-tree --no-commit-id --name-status -r OLDREV NEWREV</code>
</pre></div>Frank Koehltag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-16T17:25:11Z2013-04-16T17:25:11ZNon standard YAML format?<div><p>Mmm. Actually the code should already handle this case and I
have tests for it. Do you have an example that failed in your
account that I can look at?</p>
<p>Thanks!</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-16T18:52:03Z2013-04-16T18:52:03ZNon standard YAML format?<div><p>Sure, <a href=
"https://sensaphone.lighthouseapp.com/projects/106056/changesets/8ec11c2098320e70952d7b262bc2b1084b5e528a">
here's a broken changeset</a>.</p>
<p>Should have 2 files in the change list at the bottom...</p>
<pre>
<code>M meta/git-hooks/origin-master-post-receive
A meta/git-hooks/post-receive</code>
</pre></div>Frank Koehltag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-17T20:43:15Z2013-04-17T20:43:15ZNon standard YAML format?<div><p>Hey Frank,</p>
<p>I deployed a couple of fixes for this. It should now work as
expected with both the old format (yaml) and the new one (regular
SCM output).</p>
<p>Let me know how it goes.</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T13:28:00Z2013-04-18T13:48:36ZNon standard YAML format?<div><p>Now requests are rejected with the YAML formatting error from
before...</p>
<pre>
<code>Changes should be an array of arrays of strings like this:
"---\n- - M\n - /foo/bar/baz\n- - A\n - /foo\n"</code>
</pre>
<p>The "raw" relevant portion of the XML request looks like
this...</p>
<pre>
<code><changes>
M meta/git-hooks/origin-master-post-receive
A meta/git-hooks/post-receive
</changes></code>
</pre></div>Frank Koehltag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T14:23:25Z2013-04-18T14:24:30ZNon standard YAML format?<div><p>Hi Julien,</p>
<p>Is it possible that the changes you deployed broke our GitHub
hook? We haven't been able to push since around the time of your
deployment.</p></div>Thorsteinn Yngvi Gudmundssontag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T15:16:34Z2013-04-18T15:16:34ZNon standard YAML format?<div><p>Hi Frank,</p>
<p>I will look into it again.</p>
<p>Thorsteinn: I don't think so. We use Github ourselves and have
pushed many changes after the deploy and I made sure that they
still work. Also, the hook presumably happens separately from the
code push, and you should still be able to push code to Github even
if all your hooks are broken. Or maybe you are not using the normal
Lighthouse Github hook, and use a custom one? Can you tell me a bit
more about your setup?</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T17:32:18Z2013-04-18T17:32:20ZNon standard YAML format?<div><p>Hi, I am a developer on Thorsteinn's project and can tell you
that:</p>
<ol>
<li>
<p>We have had no commit syncing from GitHub to Lighthouse today
(last push payload according to Lighthouse was: April 17th, 2013 @
11:00 PM) despite several pushes (admittedly few).</p>
</li>
<li>
<p>AFAIK, we use a standard setup through a GitHub service hook.
Nothing has been changed recently. Running the "test hook" at
GutHub reports "Payload deployed" - whatever that means.</p>
</li>
<li>
<p>Our Lighthouse project ID is 48730.</p>
</li>
<li>
<p>I've just tried pushing and the changeset is not turning up in
Lighthouse. The hash is
<code>a1015c752d69771c33e955230921d7dd5e29273e</code>.</p>
</li>
</ol></div>Borgartag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T18:05:57Z2013-04-18T18:05:57ZNon standard YAML format?<div><p>Hi Borgar,</p>
<p>I'm taking a look.</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T18:37:53Z2013-04-18T18:37:53ZNon standard YAML format?<div><p>Hi Frank,</p>
<p>Your issues should be solved now.</p>
<p>Borgar: it seems the problem is coming from Github as the
post-commit hook is not working on some repositories: they aren't
even making the call. I have contacted them and I'm waiting to hear
back. I'll keep you posted.</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-18T19:00:29Z2013-04-18T19:00:29ZNon standard YAML format?<div><p>Confirmed, hook is working as expected.</p>
<p>Thanks for the quick turnaround, Julien!</p></div>Frank Koehltag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-19T22:52:18Z2013-04-19T22:52:18ZNon standard YAML format?<div><p>Hi Borgar,</p>
<p>I think we fixed it. Give it a try and let me know how it
goes.</p></div>Julientag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-22T11:42:12Z2013-04-22T21:11:53ZNon standard YAML format?<div><p>Yep, also think this is fixed. Top item in our feed is from
GitHub. Thanks!</p></div>Borgartag:help.lighthouseapp.com,2008-09-20:Comment/264049032013-04-22T12:44:51Z2013-04-22T12:44:53ZNon standard YAML format?<div><p>This is working for us too now. Thanks a lot!</p></div>Borgar