extlib bug

P. Chase's Avatar

P. Chase

08 Jun, 2009 03:29 PM

Hi,

I had made a ticket about 2 months ago because of a bug I found in exlib/module.rb. I got this reply today:

Dan Kubb (dkubb) updated this ticket at June 7th, 2009 @ 01:38 AM * State changed from "accepted" to "hold" @chase: are you sure about that? Making that change breaks a couple of specs.

I reviewed the logic and it looks like it does the right thing to me. Is there some sort of problem that necessitates this change?

I replied to that email with this answer:

Hi Dan,

This change is necessary for my DataMapper models, which do not work at all otherwise. For example, I have a model called APS::Models::Article, which cannot be found by the nested_const_lookup method:

def nested_const_lookup(const_name) unless equal?(Object)

 constants = []

 name.split('::').each do |part|
   const = constants.first || Object

Currently the line is:

   #constants << const.const_get(part)

so the order of the constants will NOT be APS, Models, Article.

It will be reversed, and therefore DataMapper cannot find the model.

That is why I had to change it to

   constants.unshift(const.const_get(part))

in order for my models to work.

-P. Chase

And then I got this email from you in response:

We received an email from this address that had problems being processed into a new Lighthouse ticket:

You do not have access to post to the DataMapper project.

  1. 1 Posted by P. Chase on 08 Jun, 2009 03:33 PM

    P. Chase's Avatar

    In case you didn't get my email address it's [email blocked]

  2. 2 Posted by Rick on 08 Jun, 2009 06:05 PM

    Rick's Avatar

    You're not a project member on datamapper, so you can't email into it. Let me see about tweaking this permission check to allow it on OSS projects though.

Discussions are closed to public comments.
If you need help with Lighthouse please start a new discussion.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac