Home → API Developers →

Callback behavior changed

• Edit

Joe Keeley

11 Jan, 2013 12:36 AM

Hi - it looks like the callback handler behavior changed when un-assigning a user from a ticket. Previously the callback would return "null" for assigned_user_name; now the assigned_user_name element is omitted (which unfortunately breaks our app badly). Can we be notified when changes like this are happening to the api?

Thanks!

1. Support Staff 1 Posted by Tiger Team on 11 Jan, 2013 12:39 AM

   

   There was an emergency rails security hole that forced our hand, unfortunately. It wasn't supposed to break anything.

   • Edit

2. Support Staff 2 Posted by Tiger Team on 11 Jan, 2013 12:40 AM

   

   Can you give me the exact xml you're looking for/what it used to look like?

   • Edit

3. 3 Posted by Joe Keeley on 11 Jan, 2013 12:44 AM

   

   Sure! (Yeah been a fun day with that huh? Been dealing with that on this end too).

   So, here's an example of what we received previously:

   {"version":{"assigned_user_id":null, "attachments_count":0, "body":"TEST", "body_html":"<div><p>TEST</p></div>", "closed":false, "created_at":"2012-07-17T15:53:42Z", "creator_id":99775, "diffable_attributes":{"assigned_user":192510}, "milestone_id":117059, "number":185, "permalink":"add-watchers-to-notifications", "priority":3, "project_id":68849, "state":"open", "tag":"", "title":"Add watchers to notifications", "updated_at":"2012-07-17T15:54:45Z", "user_id":99775, "version":8, "watchers_ids":[99775, 73699, 192510], "user_name":"Joe Keeley", "creator_name":"Joe Keeley", "assigned_user_name":null, "url":"http://dfsw.lighthouseapp.com/projects/68849/tickets/185", "milestone_title":"Test Milestone", "priority_name":"Low"}, "domain_name":"dfsw"}
   

   Notice the assigned_user_name in there. Now it is being omitted.

   • Edit

4. Support Staff 4 Posted by Tiger Team on 11 Jan, 2013 01:53 AM

   

   So weirdly enough I can't reproduce this on an older version of our code and gems!

   Do you know when exactly it broke? Are you sure your code didn't change?

   The crazy thing is, here's what our actual json/xml generator looks like:

         [:user_name, :creator_name, :assigned_user_name, :url, :milestone_title].each do |method|
           if value = send(method)
             options[:methods] << method
           end
         end
   

   i.e. if that thing is nil, don't put it in the xml/json dump. This code hasn't changed in, like, ever.

   • Edit

5. 5 Posted by Joe Keeley on 11 Jan, 2013 04:55 PM

   

   Hi Courtenay - my apologies - I investigated further and it looks like I updated that test case manually to make sure we covered it, but it didn't match how you send the data back. Having one of those "how did this ever work" moments...anyway we'll adjust to handle it correctly knowing this. Thank you for the quick reply.

   • Edit

6. Support Staff 6 Posted by Tiger Team on 11 Jan, 2013 05:52 PM

   

   I have those every day! comes from having a code base going back to 2007. Heh.

   • Edit

7. brandi closed this discussion on 18 Jan, 2013 06:37 PM.